Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Bump rust-rocksdb to 0.19.0 tag#26949

Merged
steviez merged 1 commit intosolana-labs:masterfrom
steviez:bump_rocks
Aug 11, 2022
Merged

Bump rust-rocksdb to 0.19.0 tag#26949
steviez merged 1 commit intosolana-labs:masterfrom
steviez:bump_rocks

Conversation

@steviez
Copy link
Copy Markdown
Contributor

@steviez steviez commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

@yhchiang-sol yhchiang-sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for upgrading rocksdb version!

Copy link
Copy Markdown
Contributor

@yhchiang-sol yhchiang-sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there're some dependencies need to be fixed.

cargo-build-bpf child: target/debug/cargo-build-sbf --sbf-sdk /var/lib/buildkite-agent/builds/gcp-agent/solana-labs/solana/sdk/bpf --manifest-path sdk/Cargo.toml --arch bpf
--
  | Updating crates.io index
  | error: failed to select a version for the requirement `librocksdb-sys = "^0.8.0"`

@behzadnouri
Copy link
Copy Markdown
Contributor

For reference, current status:
https://discord.com/channels/428295358100013066/560503042458517505/1005314069860982927

There is also a new advisory requiring an upgrade:

Crate:     rocksdb
Version:   0.18.0
Title:     Out-of-bounds read when opening multiple column families with TTL
Date:      2022-05-11
ID:        RUSTSEC-2022-0046
URL:       https://rustsec.org/advisories/RUSTSEC-2022-0046
Solution:  Upgrade to >=0.19.0

@steviez
Copy link
Copy Markdown
Contributor Author

steviez commented Aug 11, 2022

For reference, current status: https://discord.com/channels/428295358100013066/560503042458517505/1005314069860982927

There is also a new advisory requiring an upgrade:

Crate:     rocksdb
Version:   0.18.0
Title:     Out-of-bounds read when opening multiple column families with TTL
Date:      2022-05-11
ID:        RUSTSEC-2022-0046
URL:       https://rustsec.org/advisories/RUSTSEC-2022-0046
Solution:  Upgrade to >=0.19.0

Due to above, this is being pushed in despite temporarily breaking downstream-projects (spl namely)

@steviez steviez merged commit 14d9922 into solana-labs:master Aug 11, 2022
@steviez steviez added the v1.11 label Aug 11, 2022
mergify Bot pushed a commit that referenced this pull request Aug 11, 2022
@steviez steviez deleted the bump_rocks branch August 11, 2022 15:19
@steviez steviez added the v1.10 label Aug 11, 2022
mergify Bot pushed a commit that referenced this pull request Aug 11, 2022
(cherry picked from commit 14d9922)

# Conflicts:
#	Cargo.lock
#	ledger/src/blockstore_db.rs
steviez pushed a commit that referenced this pull request Aug 12, 2022
Bump rust-rocksdb to 0.19.0 tag (#26949)

(cherry picked from commit 14d9922)

Co-authored-by: steviez <steven@solana.com>
xiangzhu70 pushed a commit to xiangzhu70/solana that referenced this pull request Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants