Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

chore: update tweetnacl dependency to 1.0.3 explicitly#26907

Merged
steveluscher merged 1 commit intosolana-labs:masterfrom
steveluscher:explicit-103-tweetnacl
Aug 3, 2022
Merged

chore: update tweetnacl dependency to 1.0.3 explicitly#26907
steveluscher merged 1 commit intosolana-labs:masterfrom
steveluscher:explicit-103-tweetnacl

Conversation

@steveluscher
Copy link
Copy Markdown
Contributor

@steveluscher steveluscher commented Aug 3, 2022

Problem

tweetnacl prior to version 1.0.3 had a security vulnerability. Despite the fact that the lockfile of web3.js specifies that we import 1.0.3, the package file itself doesn't set 1.0.3 as a lower bound on what we'll accept.

Summary of Changes

  • Set v1.0.3 as the lowest version of tweetnacl that we'll accept.
cd web3.js

git clean -dfx .
npx npm@latest i
git add package.json
git add package-lock.json
git commit
git reset --hard

git clean -dfx .
npx yarn@latest
git add yarn.lock
git commit --amend

Addresses solana-foundation/solana-web3.js#1103.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 3, 2022

Codecov Report

Merging #26907 (eb70fd6) into master (1165a7f) will decrease coverage by 4.3%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   solana-labs/solana#26907       +/-   ##
===========================================
- Coverage    81.9%    77.5%     -4.4%     
===========================================
  Files         631       42      -589     
  Lines      174252     2465   -171787     
  Branches        0      352      +352     
===========================================
- Hits       142728     1911   -140817     
+ Misses      31524      424    -31100     
- Partials        0      130      +130     

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant