This repository was archived by the owner on Jan 22, 2025. It is now read-only.
chore: update tweetnacl dependency to 1.0.3 explicitly#26907
Merged
steveluscher merged 1 commit intosolana-labs:masterfrom Aug 3, 2022
steveluscher:explicit-103-tweetnacl
Merged
chore: update tweetnacl dependency to 1.0.3 explicitly#26907steveluscher merged 1 commit intosolana-labs:masterfrom steveluscher:explicit-103-tweetnacl
tweetnacl dependency to 1.0.3 explicitly#26907steveluscher merged 1 commit intosolana-labs:masterfrom
steveluscher:explicit-103-tweetnacl
Conversation
Codecov Report
@@ Coverage Diff @@
## master solana-labs/solana#26907 +/- ##
===========================================
- Coverage 81.9% 77.5% -4.4%
===========================================
Files 631 42 -589
Lines 174252 2465 -171787
Branches 0 352 +352
===========================================
- Hits 142728 1911 -140817
+ Misses 31524 424 -31100
- Partials 0 130 +130 |
This was referenced Oct 13, 2024
This was referenced Oct 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tweetnaclprior to version 1.0.3 had a security vulnerability. Despite the fact that the lockfile ofweb3.jsspecifies that we import 1.0.3, the package file itself doesn't set 1.0.3 as a lower bound on what we'll accept.Summary of Changes
tweetnaclthat we'll accept.Addresses solana-foundation/solana-web3.js#1103.