This repository was archived by the owner on Jan 22, 2025. It is now read-only.
fix: (web3.js) clear the idle timer whenever the websocket closes#26734
Merged
steveluscher merged 1 commit intosolana-labs:masterfrom Jul 25, 2022
steveluscher:cancel-idle-timer-on-close-of-websocket
Merged
fix: (web3.js) clear the idle timer whenever the websocket closes#26734steveluscher merged 1 commit intosolana-labs:masterfrom steveluscher:cancel-idle-timer-on-close-of-websocket
steveluscher merged 1 commit intosolana-labs:masterfrom
steveluscher:cancel-idle-timer-on-close-of-websocket
Conversation
steveluscher
changed the title
Codecov Report
@@ Coverage Diff @@
## master solana-labs/solana#26734 +/- ##
=======================================
Coverage 77.4% 77.5%
=======================================
Files 42 42
Lines 2462 2465 +3
Branches 351 352 +1
=======================================
+ Hits 1908 1911 +3
Misses 424 424
Partials 130 130 |
This was referenced Oct 13, 2024
This was referenced Oct 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If the websocket closes while there's an active idle timer, the connection can enter a corrupt state as described in solana-foundation/solana-web3.js#1106.
Summary of Changes
Fixes #26665.