This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Remove InMemAccountsIndex::map() and use map_internal directly#26189
Merged
brooksprumo merged 1 commit intosolana-labs:masterfrom Jun 23, 2022
Merged
Remove InMemAccountsIndex::map() and use map_internal directly#26189brooksprumo merged 1 commit intosolana-labs:masterfrom
InMemAccountsIndex::map() and use map_internal directly#26189brooksprumo merged 1 commit intosolana-labs:masterfrom
Conversation
brooksprumo
added
the
automerge
Contributor
|
automerge label removed due to a CI failure |
mergify
Bot
removed
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #26189 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 631 631
Lines 174711 174708 -3
=========================================
- Hits 143090 143086 -4
- Misses 31621 31622 +1 |
gregcusack
pushed a commit
to gregcusack/solana
that referenced
this pull request
Jun 23, 2022
gregcusack
pushed a commit
that referenced
this pull request
Jun 29, 2022
* add three gossip metrics measuring gossip loop times * add 5 metrics * rm space * rm space * Update SECURITY.md - fix nav link - add bounty split policy for duplicate reports * Add transaction index in slot to geyser plugin TransactionInfo (#25688) * Define shuffle to prep using same shuffle for multiple slices * Determine transaction indexes and plumb to execute_batch * Pair transaction_index with transaction in TransactionStatusService * Add new ReplicaTransactionInfoVersion * Plumb transaction_indexes through BankingStage * Prepare BankingStage to receive transaction indexes from PohRecorder * Determine transaction indexes in PohRecorder; add field to WorkingBank * Add PohRecorder::record unit test * Only pass starting_transaction_index around PohRecorder * Add helper structs to simplify test DashMap * Pass entry and starting-index into process_entries_with_callback together * Add tx-index checks to test_rebatch_transactions * Revert shuffle definition and use zip/unzip * Only zip/unzip if randomize * Add confirm_slot_entries test * Review nits * Add type alias to make sender docs more clear * Update SECURITY.md finish filling out the table.... * rpc: fix possible deadlock in rpc (#26051) * Add StatusCache::root_slot_deltas() and use it (#26170) * Remove InMemAccountsIndex::map() and use map_internal directly (#26189) * [quic]Decrement total_streams correctly (#26158) * remove comment * alphabetical metrics. no abbreviations * remove trailing white space * cargo fmt to update code format/readability Co-authored-by: Trent Nelson <trent@solana.com> Co-authored-by: Tyera Eulberg <tyera@solana.com> Co-authored-by: Boqin Qin(秦 伯钦) <Bobbqqin@gmail.com> Co-authored-by: Brooks Prumo <brooks@solana.com> Co-authored-by: Miles Obare <bdhobare@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While reviewing #26046, I noticed that
InMemAccountsIndex::map()wasn't used outside this struct, and adds an unnecessary indirection (IMO).Summary of Changes
Remove
InMemAccountsIndex::map()and useInMemAccountsIndex::map_internaldirectly