This repository was archived by the owner on Jan 22, 2025. It is now read-only.
serialize snapshots dir first#25889
Merged
apfitzge merged 1 commit intosolana-labs:masterfrom Jun 13, 2022
Merged
Conversation
jeffwashington
approved these changes
Jun 13, 2022
Contributor
jeffwashington
left a comment
jeffwashington
left a comment
There was a problem hiding this comment.
Yes, this seems better without negatives I can think of. Attempts to make start from snapshot faster will include using the info in the bank (in snapshots folder) and deferring using the bulk info in accounts.
Contributor
|
Added 1.10. We'd like snapshots to be generated like this asap. |
mergify Bot
pushed a commit
that referenced
this pull request
Jun 13, 2022
(cherry picked from commit 04969a2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We can begin indexing our snapshots as we untar other files, however we run into the issue that we don't the know the
current_lenof the append_vec files until we untar the snapshots directory. Currently the snapshots dir is serialized after the accounts directory.Summary of Changes
Serialize the snapshots directory before the accounts directory.
Fixes #