This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Serialize lamports per signature (backport #25364)#25805
Merged
mergify[bot] merged 1 commit intov1.10from Jun 22, 2022
Merged
Conversation
Contributor
Author
|
automerge label removed due to a CI failure |
Contributor
Author
|
automerge label removed due to a CI failure |
Codecov Report
@@ Coverage Diff @@
## v1.10 #25805 +/- ##
=========================================
+ Coverage 81.4% 82.1% +0.6%
=========================================
Files 597 628 +31
Lines 163041 171471 +8430
=========================================
+ Hits 132837 140878 +8041
- Misses 30204 30593 +389 |
6f264e9 to
30d5dc6
Compare
Contributor
Author
|
automerge label removed due to a CI failure |
30d5dc6 to
f932d4e
Compare
Contributor
|
@AshwinSekar Looks like CI is failing here; can you resolve it? Looks like someone hit this in #26074 due to their v1.10 node downloading a v1.11 snapshot. |
f932d4e to
9f01022
Compare
Contributor
Author
|
automerge label removed due to a CI failure |
9f01022 to
59f5d67
Compare
steviez
pushed a commit
to steviez/solana
that referenced
this pull request
Jul 4, 2022
Issue solana-labs#25805 backported the ability to deserialize the additional lamports_per_signature field; this change makes it such that v1.10 clients will serialize the value as well (this was left out of the initial backport).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #25364 done by Mergify.
Cherry-pick of 8caced6 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com