This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix intermittent failures in test_incremental_snapshot_download_with_crossing_full_snapshot_interval_at_startup()#24440
Merged
brooksprumo merged 1 commit intosolana-labs:masterfrom Apr 18, 2022
Conversation
…crossing_full_snapshot_interval_at_startup()
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
…crossing_full_snapshot_interval_at_startup() (solana-labs#24440)
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
…crossing_full_snapshot_interval_at_startup() (solana-labs#24440)
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
…crossing_full_snapshot_interval_at_startup() (solana-labs#24440)
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
…crossing_full_snapshot_interval_at_startup() (solana-labs#24440)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Local-cluster test
test_incremental_snapshot_download_with_crossing_full_snapshot_interval_at_startup()fails intermittently.Summary of Changes
The test made some assumptions w.r.t. how long it would take to take snapshots. However, sometimes the snapshot process was faster than expected, so the test would not check in time (it was expecting
snapshot + 1and then would seesnapshot + 2) and then fail. Now, explicitly find the specific snapshot (snapshot + 1), instead of just asking for the latest.