This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Use Release/Acquire instead of SeqCst for is_bank_drop_callback_enabled#24134
Merged
brooksprumo merged 1 commit intosolana-labs:masterfrom Apr 12, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24134 +/- ##
=========================================
- Coverage 81.8% 81.6% -0.2%
=========================================
Files 581 590 +9
Lines 158312 161012 +2700
=========================================
+ Hits 129518 131518 +2000
- Misses 28794 29494 +700 |
Contributor
Author
|
If PR #24142 gets merged, this PR will be obviated and closed. |
Contributor
Author
carllin
approved these changes
Apr 11, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Storing and loading
AccountsDb::is_bank_drop_callback_enabledusesOrdering::SeqCst, but there are no interactions with other atomics that require sequential ordering (that I could find). SinceAccountsDb::is_bank_drop_callback_enabledis loaded every timeAccountsDb::purge_slot()is called, this introduces unnecessary memory barriers/fences.Summary of Changes
Store
AccountsDb::is_bank_drop_callback_enabledwithOrdering::Releaseand load withOrdering::Acquire.