This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Start saving/loading prior_roots(_with_hash) to snapshot (backport #23844)#24074
Merged
mergify[bot] merged 1 commit intov1.10from Apr 2, 2022
Merged
Start saving/loading prior_roots(_with_hash) to snapshot (backport #23844)#24074mergify[bot] merged 1 commit intov1.10from
mergify[bot] merged 1 commit intov1.10from
Conversation
mergify
Bot
added
the
automerge
jeffwashington
force-pushed
the
mergify/bp/v1.10/pr-23844
branch
from
c5c2c05 to
a67496f
Compare
solana-grimes
removed
the
automerge
Contributor
|
😱 New commits were pushed while the automerge label was present. |
…ut does load them. Original: Start saving/loading prior_roots(_with_hash) to snapshot (#23844) * Start saving/loading prior_roots(_with_hash) to snapshot * Update runtime/src/accounts_index.rs Co-authored-by: Michael Vines <mvines@gmail.com> * Update runtime/src/accounts_index.rs Co-authored-by: Michael Vines <mvines@gmail.com> * update comment Co-authored-by: Michael Vines <mvines@gmail.com> (cherry picked from commit 396b49a)
jeffwashington
force-pushed
the
mergify/bp/v1.10/pr-23844
branch
from
a67496f to
32a01ef
Compare
brooksprumo
approved these changes
Apr 2, 2022
Contributor
There was a problem hiding this comment.
lgtm
Testing/Validation
I built ledger-tool with this PR and was successfully able to run solana-ledger-tool verify against a v1.11 snapshot (which previously failed with a v1.10 ledger-tool).
I also cherry-picked this PR on top of v1.9.14 with the same results as 👆
Lastly, I tested this PR against a "legacy" snapshot to ensure we didn't break anything inadvertently. Ledger-tool was successful again.
jeffwashington
added
automerge
mergify
Bot
removed
the
automerge
Contributor
Author
|
automerge label removed due to a CI failure |
jeffwashington
added
the
automerge
Contributor
Author
|
automerge label removed due to a CI failure |
mergify
Bot
removed
the
automerge
jeffwashington
added
the
automerge
mergify Bot
added a commit
that referenced
this pull request
Apr 2, 2022
…ut does load them. (#24074) Original: Start saving/loading prior_roots(_with_hash) to snapshot (#23844) * Start saving/loading prior_roots(_with_hash) to snapshot * Update runtime/src/accounts_index.rs Co-authored-by: Michael Vines <mvines@gmail.com> * Update runtime/src/accounts_index.rs Co-authored-by: Michael Vines <mvines@gmail.com> * update comment Co-authored-by: Michael Vines <mvines@gmail.com> (cherry picked from commit 396b49a) Co-authored-by: Jeff Washington (jwash) <wash678@gmail.com> (cherry picked from commit b157a91)
jeffwashington
pushed a commit
that referenced
this pull request
Apr 8, 2022
…ut does load them. (#24074) (#24078) Original: Start saving/loading prior_roots(_with_hash) to snapshot (#23844) * Start saving/loading prior_roots(_with_hash) to snapshot * Update runtime/src/accounts_index.rs Co-authored-by: Michael Vines <mvines@gmail.com> * Update runtime/src/accounts_index.rs Co-authored-by: Michael Vines <mvines@gmail.com> * update comment Co-authored-by: Michael Vines <mvines@gmail.com> (cherry picked from commit 396b49a) Co-authored-by: Jeff Washington (jwash) <wash678@gmail.com> (cherry picked from commit b157a91) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This began life as an automated backport.
@jeffwashington modified it to just deserialize the new fields.
This is an automatic backport of pull request #23844 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com