This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Set drop callback on first root bank#23999
Merged
carllin merged 2 commits intosolana-labs:masterfrom Apr 5, 2022
Merged
Conversation
brooksprumo
reviewed
Mar 30, 2022
Contributor
brooksprumo
left a comment
brooksprumo
left a comment
There was a problem hiding this comment.
This design looks good to me! Can you re-request a review once CI checks are ✅?
carllin
force-pushed
the
FixBlockstoreProcessor
branch
from
f1f2172 to
1774d0f
Compare
carllin
force-pushed
the
FixBlockstoreProcessor
branch
from
1774d0f to
5b2fc43
Compare
Codecov Report
@@ Coverage Diff @@
## master #23999 +/- ##
=======================================
Coverage 81.6% 81.7%
=======================================
Files 589 589
Lines 160642 160668 +26
=======================================
+ Hits 131242 131308 +66
+ Misses 29400 29360 -40 |
brooksprumo
approved these changes
Apr 5, 2022
Contributor
brooksprumo
left a comment
brooksprumo
left a comment
There was a problem hiding this comment.
This looks good to me. One thought, since we've only seen the panic on v1.10, maybe we shouldn't backport to v1.9?
mergify Bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
(cherry picked from commit 4ea59d8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
See comment here: #23970 (comment)
Summary of Changes
blockstore_processor::load_frozen_forks()now handles theBank::drop() -> purge_slot()call likeAccountsBackgroundServicewould as part of its periodic cleanupFixes #