This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Test stake split: destination delegation is at least the minimum#23456
Merged
brooksprumo merged 1 commit intosolana-labs:masterfrom Mar 2, 2022
Conversation
This was referenced Mar 2, 2022
Codecov Report
@@ Coverage Diff @@
## master #23456 +/- ##
========================================
Coverage 81.3% 81.3%
========================================
Files 572 572
Lines 155876 156099 +223
========================================
+ Hits 126815 127040 +225
+ Misses 29061 29059 -2 |
brooksprumo
deleted the
minimum-stake/test-split-destination-delegation-at-least-minimum
branch
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is a test gap in case the minimum stake delegation is raised, to ensure that the destination stake delegation ends up being at least the minimum.
Thanks to @joncinque for identifying this potential issue here: #22663 (comment)
Summary of Changes
Update test to ensure the destination stake delegation is at least the minimum stake delegation after splitting.
Ran this locally after increasing
MINIMUM_STAKE_DELEGATIONand confirmed that the tests fail as expected. Fixing the future test failures is being tracked in #23458.Miscellaneous
This is PR number 23456!