This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add MINIMUM_STAKE_DELEGATION constant#23259
Merged
brooksprumo merged 5 commits intosolana-labs:masterfrom Feb 22, 2022
Merged
Conversation
18 tasks
brooksprumo
commented
Feb 21, 2022
Codecov Report
@@ Coverage Diff @@
## master #23259 +/- ##
========================================
Coverage 81.3% 81.3%
========================================
Files 570 571 +1
Lines 155438 155665 +227
========================================
+ Hits 126452 126665 +213
- Misses 28986 29000 +14 |
CriesofCarrots
previously approved these changes
Feb 22, 2022
Contributor
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
wfm! It will be nice to have this clarity for #22663
r+ one nit
Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
mergify
Bot
dismissed
CriesofCarrots’s stale review
Pull request has been modified.
Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
brooksprumo
deleted the
minimum-stake/add-constant-and-tests-no-behavior-changes
branch
ryoqun
reviewed
Feb 23, 2022
Comment on lines
+6726
to
+6728
| /// The stake program currently allows delegations below the minimum stake delegation (see also | ||
| /// `test_delegate_minimum_stake_delegation()`). This is not the ultimate desired behavior, | ||
| /// but this test ensures the existing behavior is not changed inadvertently. |
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Mar 4, 2022
Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There are not tests for enforcing the minimum stake delegation.
Summary of Changes
MINIMUM_STAKE_DELEGATIONconstantMINIMUM_STAKE_DELEGATIONconstant in existing testsNOTE: No behavior was changed in this PR.
Context
In an effort to simplify #22663, I've pulled out the changes from that PR that pertain to just the tests and adding the constant. This should make it simpler to review (1) this PR, and then (2) once I rebase the other PR on this one, it'll be quite obvious what has and has not changed.