This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Reject close of active vote accounts (backport #22651)#22895
Merged
mergify[bot] merged 9 commits intov1.8from Feb 7, 2022
Merged
Reject close of active vote accounts (backport #22651)#22895mergify[bot] merged 9 commits intov1.8from
mergify[bot] merged 9 commits intov1.8from
Conversation
* 10461 Reject close of vote accounts unless it earned no credits in the previous epoch. This is checked by comparing current epoch (from clock sysvar) with the most recent epoch with credits in vote state. (cherry picked from commit 75563f6) # Conflicts: # programs/vote/src/vote_processor.rs # programs/vote/src/vote_state/mod.rs # runtime/src/bank.rs # sdk/program/src/instruction.rs # sdk/program/src/program_error.rs # storage-proto/proto/transaction_by_addr.proto # storage-proto/src/convert.rs
mergify
Bot
added
conflicts
automerge
Contributor
Author
|
automerge label removed due to a CI failure |
added 2 commits
February 3, 2022 11:54
mergify
Bot
added
automerge
Contributor
Author
|
automerge label removed due to a CI failure |
| None | ||
| }; | ||
| vote_state::withdraw(me, lamports, to, &signers, rent_sysvar.as_deref()) | ||
| let clock_if_feature_active = if invoke_context.is_feature_active( |
Contributor
There was a problem hiding this comment.
Aha. I was wondering why you had to redo this change, but I see the refactor to programs/vote/src/vote_processor.rs doesn't exist on v1.8. Can you also remove that dangling file here?
mergify
Bot
added
automerge
Contributor
Author
|
automerge label removed due to a CI failure |
mergify
Bot
added
the
automerge
Contributor
Author
|
automerge label removed due to a CI failure |
mergify
Bot
removed
the
automerge
mergify
Bot
added
automerge
Contributor
Author
|
automerge label removed due to a CI failure |
t-nelson
approved these changes
Feb 4, 2022
|
|
||
| /// Accounts data budget exceeded | ||
| #[error("Requested account data allocation exceeded the accounts data budget")] | ||
| AccountsDataBudgetExceeded, |
Contributor
There was a problem hiding this comment.
Welcome to the v1.8 branch! 😅
mergify
Bot
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## v1.8 #22895 +/- ##
========================================
Coverage 81.6% 81.7%
========================================
Files 464 464
Lines 131709 132168 +459
========================================
+ Hits 107555 108034 +479
+ Misses 24154 24134 -20 |
Contributor
|
😱 New commits were pushed while the automerge label was present. |
solana-grimes
removed
the
automerge
mergify
Bot
added
automerge
Contributor
Author
|
automerge label removed due to a CI failure |
mergify
Bot
added
the
automerge
Contributor
Author
|
automerge label removed due to a CI failure |
mergify
Bot
added
automerge
Contributor
Author
|
automerge label removed due to a CI failure |
mergify
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #22651 done by Mergify.
Cherry-pick of 75563f6 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com