This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Perf: Store deserialized sysvars in the sysvars cache#22455
Merged
mergify[bot] merged 2 commits intosolana-labs:masterfrom Jan 13, 2022
Merged
Perf: Store deserialized sysvars in the sysvars cache#22455mergify[bot] merged 2 commits intosolana-labs:masterfrom
mergify[bot] merged 2 commits intosolana-labs:masterfrom
Conversation
jstarry
force-pushed
the
perf/sysvar-cache
branch
2 times, most recently
from
f66c52e to
98135f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #22455 +/- ##
========================================
Coverage 81.1% 81.1%
========================================
Files 555 555
Lines 150561 150664 +103
========================================
+ Hits 122183 122324 +141
+ Misses 28378 28340 -38 |
Contributor
Author
|
@behzadnouri I opted not to use your commit and chose to only cache the sysvars which need to be requested from the invoke context. I think this approach is simpler, let me know what you think, thanks! |
jackcmay
reviewed
Jan 12, 2022
jackcmay
reviewed
Jan 12, 2022
jstarry
force-pushed
the
perf/sysvar-cache
branch
from
cdedea8 to
a59c68b
Compare
Contributor
|
Looking good, have you benched the differences? |
Contributor
Author
working on it |
jstarry
force-pushed
the
perf/sysvar-cache
branch
from
683c890 to
3e56074
Compare
Contributor
Author
|
Added a bench.. seeing a 25% perf improvement for end to end vote processing (including sigverify, account loading, etc) |
t-nelson
approved these changes
Jan 13, 2022
jackcmay
approved these changes
Jan 13, 2022
mergify Bot
pushed a commit
that referenced
this pull request
Jan 13, 2022
* Perf: Store deserialized sysvars in sysvars cache * add bench (cherry picked from commit 2370e61) # Conflicts: # program-runtime/src/invoke_context.rs # program-runtime/src/sysvar_cache.rs # program-test/src/lib.rs # programs/address-lookup-table/src/processor.rs # programs/bpf_loader/src/syscalls.rs # programs/stake/src/stake_instruction.rs # programs/vote/src/vote_instruction.rs # programs/vote/src/vote_state/mod.rs # runtime/benches/bank.rs # runtime/src/bank.rs # runtime/src/bank/sysvar_cache.rs
mergify Bot
pushed a commit
that referenced
this pull request
Jan 13, 2022
* Perf: Store deserialized sysvars in sysvars cache * add bench (cherry picked from commit 2370e61) # Conflicts: # program-runtime/src/invoke_context.rs # program-runtime/src/sysvar_cache.rs # programs/bpf_loader/src/syscalls.rs # programs/stake/src/stake_instruction.rs # programs/vote/src/vote_instruction.rs # runtime/src/bank.rs # runtime/src/bank/sysvar_cache.rs
jstarry
added a commit
that referenced
this pull request
Jan 15, 2022
* Perf: Store deserialized sysvars in sysvars cache * add bench
jstarry
added a commit
to jstarry/solana
that referenced
this pull request
Jan 21, 2022
jstarry
added a commit
to jstarry/solana
that referenced
this pull request
Jan 22, 2022
jstarry
added a commit
that referenced
this pull request
Jan 22, 2022
Contributor
|
This PR has been automatically locked since there has not been any activity in past 14 days after it was merged. |
ryoqun
reviewed
Feb 7, 2023
| ) | ||
| }); | ||
|
|
||
| new.fill_missing_sysvar_cache_entries(); |
Contributor
There was a problem hiding this comment.
this is a new invocation to cover this new code-path (ref: https://github.com/solana-labs/solana/pull/30158/files#r1098222823 #30158)
mergify
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Deserializing sysvars is slow
Summary of Changes
Fixes #