This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Cleanup serde snapshot's "future" to "newer"#22431
Merged
brooksprumo merged 1 commit intosolana-labs:masterfrom Jan 13, 2022
Merged
Cleanup serde snapshot's "future" to "newer"#22431brooksprumo merged 1 commit intosolana-labs:masterfrom
brooksprumo merged 1 commit intosolana-labs:masterfrom
Conversation
brooksprumo
changed the title
brooksprumo
commented
Jan 11, 2022
| } | ||
| match serde_style { | ||
| SerdeStyle::Newer => INTO!(TypeContextFuture), | ||
| SerdeStyle::Newer => INTO!(newer), |
Contributor
Author
There was a problem hiding this comment.
When I add a new case here, the INTO! macro was complaining about using an ident that had scoping (i.e. newer::Context and older::Context). So the simple fix is to have the macro take the serde style, since the Context part is fixed.
|
|
||
| mod common; | ||
| mod future; | ||
| mod newer; |
Contributor
Author
There was a problem hiding this comment.
Renamed future to newer, which caused the file to be renamed as well.
Codecov Report
@@ Coverage Diff @@
## master #22431 +/- ##
=========================================
- Coverage 81.1% 81.1% -0.1%
=========================================
Files 553 553
Lines 150439 150439
=========================================
- Hits 122075 122052 -23
- Misses 28364 28387 +23 |
mergify Bot
pushed a commit
that referenced
this pull request
Feb 1, 2022
(cherry picked from commit 9c3144e) # Conflicts: # runtime/src/serde_snapshot.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #21604, I likely need to add a new Snapshot Version to add
accounts_data_lento the snapshot. While starting on that, I found a few bits to cleanup/refactor (based on the original PR #9980).In particular, I've renamed the "styles" so any mentions of "future" are now "newer" (more details here).