Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Refactor: Remove KeyedAccounts (2)#22274

Merged
Lichtso merged 5 commits intosolana-labs:masterfrom
Lichtso:refactor/remove_keyed_accounts_2
Jan 5, 2022
Merged

Refactor: Remove KeyedAccounts (2)#22274
Lichtso merged 5 commits intosolana-labs:masterfrom
Lichtso:refactor/remove_keyed_accounts_2

Conversation

@Lichtso
Copy link
Copy Markdown
Contributor

@Lichtso Lichtso commented Jan 4, 2022

Problem

Continuation of #22226 as there are still many use sites of KeyedAccount to be replaced.

Summary of Changes

Removes use sites of KeyedAccount in tests of:

  • invoke_context.rs
  • message_processor.rs
  • bank.rs
  • BPF serialization

Also, adds InstructionContext::get_signers()
and improves error messages when modifying BorrowedAccounts.

Fixes #

@Lichtso Lichtso force-pushed the refactor/remove_keyed_accounts_2 branch from 1b4eea9 to 6afbfc0 Compare January 4, 2022 16:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 4, 2022

Codecov Report

Merging #22274 (c6b145a) into master (1460f00) will increase coverage by 0.0%.
The diff coverage is 93.2%.

@@           Coverage Diff           @@
##           master   #22274   +/-   ##
=======================================
  Coverage    81.0%    81.1%           
=======================================
  Files         523      523           
  Lines      146793   146781   -12     
=======================================
+ Hits       119044   119090   +46     
+ Misses      27749    27691   -58     

@Lichtso Lichtso force-pushed the refactor/remove_keyed_accounts_2 branch from 6afbfc0 to c6b145a Compare January 4, 2022 22:20
@Lichtso Lichtso merged commit 9f63493 into solana-labs:master Jan 5, 2022
@Lichtso Lichtso deleted the refactor/remove_keyed_accounts_2 branch January 5, 2022 08:39
@Lichtso Lichtso mentioned this pull request Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant