This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Refactor: Remove KeyedAccounts (2)#22274
Merged
Lichtso merged 5 commits intosolana-labs:masterfrom Jan 5, 2022
Merged
Conversation
1b4eea9 to
6afbfc0
Compare
Codecov Report
@@ Coverage Diff @@
## master #22274 +/- ##
=======================================
Coverage 81.0% 81.1%
=======================================
Files 523 523
Lines 146793 146781 -12
=======================================
+ Hits 119044 119090 +46
+ Misses 27749 27691 -58 |
Improves error messages when modifying borrowed accounts.
6afbfc0 to
c6b145a
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Continuation of #22226 as there are still many use sites of
KeyedAccountto be replaced.Summary of Changes
Removes use sites of
KeyedAccountin tests of:Also, adds
InstructionContext::get_signers()and improves error messages when modifying
BorrowedAccounts.Fixes #