This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add error specific timings in per-program metrics logging#22225
Merged
carllin merged 1 commit intosolana-labs:masterfrom Jan 3, 2022
Merged
Add error specific timings in per-program metrics logging#22225carllin merged 1 commit intosolana-labs:masterfrom
carllin merged 1 commit intosolana-labs:masterfrom
Conversation
carllin
changed the title
carllin
changed the title
carllin
commented
Jan 2, 2022
| .accumulated_units | ||
| .saturating_add(other.accumulated_units); | ||
| program_timing.count = program_timing.count.saturating_add(other.count); | ||
| program_timing.accumulate_program_timings(other); |
Contributor
Author
There was a problem hiding this comment.
here was the bug, didn't account for the newly added errored_txs_compute_consumed
carllin
commented
Jan 2, 2022
Comment on lines
+154
to
+159
| ("errored_units", time.total_errored_units, i64), | ||
| ("count", time.count, i64), | ||
| ( | ||
| "errored_count", | ||
| time.errored_txs_compute_consumed.len(), | ||
| i64 |
Contributor
Author
There was a problem hiding this comment.
The new per-program error compute units and number of errored transactions
Codecov Report
@@ Coverage Diff @@
## master #22225 +/- ##
=======================================
Coverage 81.0% 81.0%
=======================================
Files 523 523
Lines 146497 146558 +61
=======================================
+ Hits 118741 118797 +56
- Misses 27756 27761 +5 |
tao-stones
approved these changes
Jan 3, 2022
| .accumulated_units | ||
| .saturating_add(other.accumulated_units); | ||
| program_timing.count = program_timing.count.saturating_add(other.count); | ||
| program_timing.accumulate_program_timings(other); |
mergify Bot
pushed a commit
that referenced
this pull request
Jan 3, 2022
(cherry picked from commit 0055929) # Conflicts: # program-runtime/src/timings.rs
mergify Bot
pushed a commit
that referenced
this pull request
Jan 3, 2022
(cherry picked from commit 0055929)
carllin
added a commit
that referenced
this pull request
Jan 3, 2022
(cherry picked from commit 0055929)
carllin
added a commit
that referenced
this pull request
Jan 4, 2022
(cherry picked from commit 0055929)
carllin
added a commit
that referenced
this pull request
Jan 4, 2022
(cherry picked from commit 0055929)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ExecuteDetailsTimings::accumulate(), which didn't accumulate the errors inside the program timingsSummary of Changes
ExecuteDetailsTimings::accumulate(), add testsFixes #