This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Limit number of accounts that a transaction can lock#22201
Merged
jstarry merged 1 commit intosolana-labs:masterfrom Jan 4, 2022
Merged
Limit number of accounts that a transaction can lock#22201jstarry merged 1 commit intosolana-labs:masterfrom
jstarry merged 1 commit intosolana-labs:masterfrom
Conversation
jstarry
force-pushed
the
max-tx-locked-accounts
branch
from
b44eeb9 to
81f9a07
Compare
jstarry
force-pushed
the
max-tx-locked-accounts
branch
from
81f9a07 to
9168700
Compare
jstarry
force-pushed
the
max-tx-locked-accounts
branch
from
9168700 to
5cecb4c
Compare
Codecov Report
@@ Coverage Diff @@
## master #22201 +/- ##
===========================================
+ Coverage 70.1% 81.0% +10.9%
===========================================
Files 35 523 +488
Lines 2076 146549 +144473
Branches 296 0 -296
===========================================
+ Hits 1456 118844 +117388
- Misses 519 27705 +27186
+ Partials 101 0 -101 |
Contributor
|
Why move the account validation out of the sanitization process? |
Contributor
Author
In my opinion, sanitization is more for things like bounds checking. Validation of requested account locks for a transaction is something different governed by the runtime and makes more sense to handle at the point of account locking. |
mergify Bot
pushed a commit
that referenced
this pull request
Jan 4, 2022
(cherry picked from commit 2b5e00d) # Conflicts: # accountsdb-plugin-postgres/src/postgres_client/postgres_client_transaction.rs # runtime/src/accounts.rs # runtime/src/bank.rs # sdk/src/feature_set.rs # sdk/src/transaction/error.rs # storage-proto/proto/transaction_by_addr.proto # storage-proto/src/convert.rs
mergify Bot
added a commit
that referenced
this pull request
Jan 4, 2022
#22263) * Limit number of accounts that a transaction can lock (#22201) (cherry picked from commit 2b5e00d) # Conflicts: # accountsdb-plugin-postgres/src/postgres_client/postgres_client_transaction.rs # runtime/src/accounts.rs # runtime/src/bank.rs # sdk/src/feature_set.rs # sdk/src/transaction/error.rs # storage-proto/proto/transaction_by_addr.proto # storage-proto/src/convert.rs * resolve conflicts Co-authored-by: Justin Starry <justin@solana.com>
Closed
jstarry
added
the
feature-gate
65 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
No limit to the number of accounts that a transaction can lock
Summary of Changes
SanitizedTransaction::get_account_locks()Fixes #21748
Feature Gate Issue #24046