This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fixed issue #22124 -- missing historical data if slot updated later.#22193
Merged
lijunwangs merged 2 commits intosolana-labs:masterfrom Jan 4, 2022
Merged
Conversation
lijunwangs
commented
Dec 30, 2021
| Err(err) => { | ||
| return Err(AccountsDbPluginError::Custom(Box::new(AccountsDbPluginPostgresError::DataSchemaError { | ||
| msg: format!( | ||
| "Error in preparing for the accounts update PostgreSQL database: {} host: {:?} user: {:?} config: {:?}", |
Contributor
Author
There was a problem hiding this comment.
account audit update
lijunwangs
commented
Dec 30, 2021
| } | ||
| } | ||
|
|
||
| /// Internal function for updating or inserting a single account |
Contributor
Author
There was a problem hiding this comment.
inserting into account_audit table
Codecov Report
@@ Coverage Diff @@
## master #22193 +/- ##
=========================================
- Coverage 81.1% 81.0% -0.1%
=========================================
Files 523 523
Lines 146478 146521 +43
=========================================
- Hits 118820 118817 -3
- Misses 27658 27704 +46 |
carllin
approved these changes
Jan 3, 2022
Contributor
|
Lijun and I also discussed some possibilities for integration tests to catch future regressions like this. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the account notification via plugin -- some account update with older slots may come after the updates of those with newer slot. It is found the account_audit table misses such updates.
Summary of Changes
In case updates are rejected in the account table because they are "old", directly insert into the account_audit table for keeping historical data.
Fixes #22124