This repository was archived by the owner on Jan 22, 2025. It is now read-only.
discards serialized gossip crds votes if cannot parse tx#22129
Merged
behzadnouri merged 1 commit intosolana-labs:masterfrom Dec 29, 2021
Merged
discards serialized gossip crds votes if cannot parse tx#22129behzadnouri merged 1 commit intosolana-labs:masterfrom
behzadnouri merged 1 commit intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22129 +/- ##
=======================================
Coverage 81.2% 81.2%
=======================================
Files 520 520
Lines 145949 145959 +10
=======================================
+ Hits 118533 118542 +9
- Misses 27416 27417 +1 |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 29, 2021
(cherry picked from commit c9c7862) # Conflicts: # gossip/src/crds_value.rs
t-nelson
reviewed
Dec 29, 2021
| let self_pubkey = self.id(); | ||
| let now = timestamp(); | ||
| let vote = Vote::new(self_pubkey, vote, now); | ||
| let vote = Vote::new(self_pubkey, vote, now).unwrap(); |
Contributor
There was a problem hiding this comment.
Any concerns with externally controlled info making it to this unwrap?
Contributor
Author
There was a problem hiding this comment.
I don't think so. Unless replay is pushing invalid votes.
These are local nodes votes.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The crds value is invalid if cannot parse tx into a vote.
Summary of Changes
Discard serialized gossip crds votes if cannot parse tx.