This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Refactor: CPI Instruction Recording#22111
Merged
Lichtso merged 4 commits intosolana-labs:masterfrom Dec 25, 2021
Merged
Conversation
uses the indices gathered from instruction_accounts instead.
Codecov Report
@@ Coverage Diff @@
## master #22111 +/- ##
=========================================
- Coverage 81.3% 81.2% -0.1%
=========================================
Files 519 519
Lines 145721 145734 +13
=========================================
- Hits 118475 118447 -28
- Misses 27246 27287 +41 |
This was referenced Jan 9, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Another followup of #22102, because CPI instruction recording is currently the responsibility of the caller of
InvokeContext::process_instruction(), clonesInstructions and compiles them, but neither of that is necessary.Summary of Changes
Vec<Option<Rc<RefCell<Vec<Instruction>>>>>intoOption<Rc<RefCell<Vec<Vec<Instruction>>>>>by unifying allInstructionRecorders of a transaction into one.CompiledInstructionby recycling the account indices gathered forinstruction_accounts.Instructions frominstruction_recorder.record_instruction(instruction.clone());InvokeContext::process_instruction()Fixes #