This repository was archived by the owner on Jan 22, 2025. It is now read-only.
banks-client: Update error type to BanksClientError#22058
Merged
joncinque merged 1 commit intosolana-labs:masterfrom Dec 24, 2021
Merged
banks-client: Update error type to BanksClientError#22058joncinque merged 1 commit intosolana-labs:masterfrom
BanksClientError#22058joncinque merged 1 commit intosolana-labs:masterfrom
Conversation
Contributor
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
Yep, looks perfect. Thanks for doing this!
We can noodle on this for a bit, but probably pull the trigger on master fairly soon.
joncinque
force-pushed
the
banks-client-error
branch
from
8d40286 to
7603754
Compare
Codecov Report
@@ Coverage Diff @@
## master #22058 +/- ##
=======================================
Coverage 81.3% 81.3%
=======================================
Files 519 519
Lines 145773 145773
=======================================
+ Hits 118568 118569 +1
+ Misses 27205 27204 -1 |
Contributor
Author
|
Merging to unblock #22084 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We want to encapsulate errors returned from
BanksClient.Summary of Changes
Have all functions on
BanksClientreturnBanksClientErrorinstead oftransport::Errororio::Error.This builds on top of #21739, so only the last commit needs to be looked at. It's more for visibility, whenever we want to land this.
This is not for right now, but these were the changes made to test what would break in SPL, being fixed in solana-labs/solana-program-library#2657
Fixes #