This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix transaction pk violation#22057
Merged
lijunwangs merged 2 commits intosolana-labs:masterfrom Dec 22, 2021
Merged
Conversation
…on might be replayed due to validator restart.
Codecov Report
@@ Coverage Diff @@
## master #22057 +/- ##
=======================================
Coverage 81.3% 81.3%
=======================================
Files 517 517
Lines 145582 145582
=======================================
+ Hits 118418 118459 +41
+ Misses 27164 27123 -41 |
carllin
approved these changes
Dec 22, 2021
mergify Bot
pushed a commit
that referenced
this pull request
Dec 22, 2021
* Handle PK violation issue for transaction notification. The transaction might be replayed due to validator restart. (cherry picked from commit d6de4a2)
mergify Bot
added a commit
that referenced
this pull request
Dec 23, 2021
* Handle PK violation issue for transaction notification. The transaction might be replayed due to validator restart. (cherry picked from commit d6de4a2) Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the validator restarts some of the transaction earlier notified might be re-notified if it is restoring from an older snapshots.
Summary of Changes
Handle the conflict on (slot, signature), on conflict, overwrites.
Fixes #22003