Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

new net-stats require a new table#21996

Merged
jbiseda merged 2 commits intosolana-labs:masterfrom
jbiseda:fix_new_netstats
Dec 18, 2021
Merged

new net-stats require a new table#21996
jbiseda merged 2 commits intosolana-labs:masterfrom
jbiseda:fix_new_netstats

Conversation

@jbiseda
Copy link
Copy Markdown
Contributor

@jbiseda jbiseda commented Dec 18, 2021 •
edited
Loading

Problem

net-stats table is used by net-stats.sh, addition of new net stats values are silently dropped

Summary of Changes

  • log to new "net-stats-validator" table
  • increase logging frequency to 2s

Fixes #

t-nelson
t-nelson reviewed Dec 18, 2021
View reviewed changes
Comment thread core/src/system_monitor_service.rs Outdated
@jbiseda jbiseda added the v1.9 label Dec 18, 2021
jeffwashington
jeffwashington approved these changes Dec 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 18, 2021

Codecov Report

Merging #21996 (4c212e6) into master (97a1fa1) will increase coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21996   +/-   ##
=======================================
  Coverage    81.4%    81.4%           
=======================================
  Files         517      517           
  Lines      145463   145463           
=======================================
+ Hits       118417   118429   +12     
+ Misses      27046    27034   -12

@carllin carllin added the v1.8 label Dec 18, 2021
@jbiseda jbiseda merged commit 3fe942a into solana-labs:master Dec 18, 2021
mergify Bot pushed a commit that referenced this pull request Dec 18, 2021
@jbiseda
new net-stats require a new table (#21996)
70752d6 
(cherry picked from commit 3fe942a)

# Conflicts:
#	core/src/system_monitor_service.rs
@mergify mergify Bot mentioned this pull request Dec 18, 2021
Merged
mergify Bot pushed a commit that referenced this pull request Dec 18, 2021
@jbiseda
new net-stats require a new table (#21996)
a61488e 
(cherry picked from commit 3fe942a)
@jbiseda jbiseda deleted the fix_new_netstats branch December 18, 2021 08:13
@mergify mergify Bot mentioned this pull request Dec 18, 2021
Merged
mergify Bot added a commit that referenced this pull request Dec 18, 2021
@mergify @jbiseda
new net-stats require a new table (#21996) (#22000)
91657ba 
(cherry picked from commit 3fe942a)

Co-authored-by: Jeff Biseda <jbiseda@gmail.com>
mergify Bot added a commit that referenced this pull request Dec 18, 2021
@mergify @jbiseda
new net-stats require a new table (backport #21996) (#21999)
ddef156 
* new net-stats require a new table (#21996)

(cherry picked from commit 3fe942a)

# Conflicts:
#	core/src/system_monitor_service.rs

* merge

Co-authored-by: Jeff Biseda <jbiseda@gmail.com>
@brooksprumo brooksprumo mentioned this pull request Jan 5, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@t-nelson t-nelson t-nelson approved these changes

@carllin carllin carllin approved these changes

@jeffwashington jeffwashington jeffwashington approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbiseda @t-nelson @carllin @jeffwashington