Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Consume from AccountsDataMeter#21994

Merged
brooksprumo merged 2 commits intosolana-labs:masterfrom
brooksprumo:accounts-data-len-4
Jan 4, 2022
Merged

Consume from AccountsDataMeter#21994
brooksprumo merged 2 commits intosolana-labs:masterfrom
brooksprumo:accounts-data-len-4

Conversation

@brooksprumo
Copy link
Copy Markdown
Contributor

@brooksprumo brooksprumo commented Dec 17, 2021

Problem

Instructions that change account data sizes are not tracked against the AccountsDataMeter.

Summary of Changes

Processing instructions that change account data sizes consumes from AccountsDataMeter.

@brooksprumo brooksprumo changed the title accounts data len 4 Consume from AccountsDataMeter Dec 17, 2021
@brooksprumo brooksprumo added the work in progress This isn't quite right yet label Dec 17, 2021
@brooksprumo
Copy link
Copy Markdown
Contributor Author

I still want to figure out how to add tests. Also, might be able to remove the Rc<RefCell<>> from around AccountsDataMeter.

@brooksprumo brooksprumo force-pushed the accounts-data-len-4 branch 3 times, most recently from 856628f to f5d94e3 Compare December 21, 2021 20:32
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 21, 2021

Codecov Report

Merging #21994 (3b90131) into master (ce6c76e) will increase coverage by 0.0%.
The diff coverage is 78.8%.

@@           Coverage Diff            @@
##           master   #21994    +/-   ##
========================================
  Coverage    81.0%    81.1%            
========================================
  Files         523      523            
  Lines      146497   146614   +117     
========================================
+ Hits       118760   118918   +158     
+ Misses      27737    27696    -41     

@brooksprumo brooksprumo force-pushed the accounts-data-len-4 branch 5 times, most recently from cbf4a23 to 003480d Compare December 27, 2021 17:59
@brooksprumo brooksprumo added the noCI Suppress CI on this Pull Request label Dec 27, 2021
@brooksprumo
Copy link
Copy Markdown
Contributor Author

brooksprumo commented Jan 3, 2022

Now based on top of #22226. Blocked on that PR merging.

@brooksprumo brooksprumo added blocked Unable to proceed and removed work in progress This isn't quite right yet labels Jan 3, 2022
@brooksprumo brooksprumo added CI Pull Request is ready to enter CI and removed noCI Suppress CI on this Pull Request blocked Unable to proceed labels Jan 3, 2022
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Jan 3, 2022
@brooksprumo brooksprumo marked this pull request as ready for review January 4, 2022 03:43
@brooksprumo brooksprumo requested a review from Lichtso January 4, 2022 03:44
Comment thread runtime/src/bank.rs
@brooksprumo brooksprumo requested a review from Lichtso January 4, 2022 13:22
@brooksprumo brooksprumo merged commit 1460f00 into solana-labs:master Jan 4, 2022
@brooksprumo brooksprumo deleted the accounts-data-len-4 branch January 4, 2022 16:00
mergify Bot pushed a commit that referenced this pull request Jan 6, 2022
(cherry picked from commit 1460f00)

# Conflicts:
#	program-runtime/src/invoke_context.rs
mergify Bot added a commit that referenced this pull request Jan 6, 2022
* Consume from AccountsDataMeter (#21994)

(cherry picked from commit 1460f00)

# Conflicts:
#	program-runtime/src/invoke_context.rs

* fixup! conflicts

* fix tests for v1.9

* fixup! clippy

Co-authored-by: Brooks Prumo <brooks@solana.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants