This repository was archived by the owner on Jan 22, 2025. It is now read-only.
removes Select in favor of recv_timeout/try_iter#21981
Merged
behzadnouri merged 1 commit intosolana-labs:masterfrom Dec 18, 2021
Merged
removes Select in favor of recv_timeout/try_iter#21981behzadnouri merged 1 commit intosolana-labs:masterfrom
behzadnouri merged 1 commit intosolana-labs:masterfrom
Conversation
behzadnouri
force-pushed
the
rm-select
branch
from
b8ced6c to
0fc6530
Compare
crossbeam_channel::Select::ready_timeout might return with success spuriously.
behzadnouri
force-pushed
the
rm-select
branch
from
0fc6530 to
4fd70ff
Compare
Codecov Report
@@ Coverage Diff @@
## master #21981 +/- ##
========================================
Coverage 81.2% 81.3%
========================================
Files 516 516
Lines 144284 144933 +649
========================================
+ Hits 117256 117916 +660
+ Misses 27028 27017 -11 |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 18, 2021
crossbeam_channel::Select::ready_timeout might return with success spuriously. (cherry picked from commit 7476dfe)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
crossbeam_channel::Select::ready_timeoutmight return with success spuriously.Summary of Changes
removed
Selectin favor ofrecv_timeout/try_iter.