This repository was archived by the owner on Jan 22, 2025. It is now read-only.
removes next_shred_index from return value of entries to shreds api#21961
Merged
behzadnouri merged 1 commit intosolana-labs:masterfrom Dec 17, 2021
Merged
removes next_shred_index from return value of entries to shreds api#21961behzadnouri merged 1 commit intosolana-labs:masterfrom
behzadnouri merged 1 commit intosolana-labs:masterfrom
Conversation
next-shred-index is already readily available from returned data shreds. The commit simplifies the api for upcoming changes to erasure coding schema which will require explicit tracking of indices for coding shreds as well as data shreds.
behzadnouri
force-pushed
the
rm-last-shred-index
branch
from
45965ed to
32958bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #21961 +/- ##
=========================================
- Coverage 81.2% 81.2% -0.1%
=========================================
Files 516 516
Lines 144369 144368 -1
=========================================
- Hits 117351 117339 -12
- Misses 27018 27029 +11 |
mergify Bot
added a commit
that referenced
this pull request
Dec 17, 2021
…21961) (#21980) next-shred-index is already readily available from returned data shreds. The commit simplifies the api for upcoming changes to erasure coding schema which will require explicit tracking of indices for coding shreds as well as data shreds. (cherry picked from commit 89d66c3) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Closed
mergify Bot
pushed a commit
that referenced
this pull request
Feb 5, 2022
…21961) next-shred-index is already readily available from returned data shreds. The commit simplifies the api for upcoming changes to erasure coding schema which will require explicit tracking of indices for coding shreds as well as data shreds. (cherry picked from commit 89d66c3) # Conflicts: # core/benches/shredder.rs # core/src/broadcast_stage/broadcast_duplicates_run.rs # core/src/broadcast_stage/broadcast_fake_shreds_run.rs # core/src/broadcast_stage/fail_entry_verification_broadcast_run.rs # core/src/broadcast_stage/standard_broadcast_run.rs # gossip/src/duplicate_shred.rs # ledger/src/blockstore.rs # ledger/src/shred.rs # ledger/tests/shred.rs
mergify Bot
added a commit
that referenced
this pull request
Feb 5, 2022
…backport #21961) (#22965) * removes next_shred_index from return value of entries to shreds api (#21961) next-shred-index is already readily available from returned data shreds. The commit simplifies the api for upcoming changes to erasure coding schema which will require explicit tracking of indices for coding shreds as well as data shreds. (cherry picked from commit 89d66c3) # Conflicts: # core/benches/shredder.rs # core/src/broadcast_stage/broadcast_duplicates_run.rs # core/src/broadcast_stage/broadcast_fake_shreds_run.rs # core/src/broadcast_stage/fail_entry_verification_broadcast_run.rs # core/src/broadcast_stage/standard_broadcast_run.rs # gossip/src/duplicate_shred.rs # ledger/src/blockstore.rs # ledger/src/shred.rs # ledger/tests/shred.rs * removes mergify merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
next-shred-index is already readily available from returned data shreds.
Summary of Changes
The commit simplifies the api for upcoming changes to erasure coding
schema which will require explicit tracking of indices for coding shreds
as well as data shreds.