This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Update getSignaturesForAddress and getConfirmedSignaturesForAddress2 RPC call description#21955
Merged
mergify[bot] merged 5 commits intosolana-labs:masterfrom Dec 16, 2021
Merged
Conversation
Contributor
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
Fair, makes sense to be more precise. Wdyt of my proposed wording?
Also, can you wrap to 80 chars?
Thank you!
Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
Contributor
|
I just pushed a little commit making the two doc blocks the same. Thank you for helping improve our docs! |
CriesofCarrots
added
the
automerge
mergify Bot
pushed a commit
that referenced
this pull request
Dec 16, 2021
…RPC call description (#21955) * Update jsonrpc-api.md * Update docs/src/developing/clients/jsonrpc-api.md Co-authored-by: Tyera Eulberg <teulberg@gmail.com> * Wrap 80chars * Update docs/src/developing/clients/jsonrpc-api.md Co-authored-by: Tyera Eulberg <teulberg@gmail.com> (cherry picked from commit 3398f5a)
mergify Bot
added a commit
that referenced
this pull request
Dec 16, 2021
…RPC call description (#21955) (#21960) * Update jsonrpc-api.md * Update docs/src/developing/clients/jsonrpc-api.md Co-authored-by: Tyera Eulberg <teulberg@gmail.com> * Wrap 80chars * Update docs/src/developing/clients/jsonrpc-api.md Co-authored-by: Tyera Eulberg <teulberg@gmail.com> (cherry picked from commit 3398f5a) Co-authored-by: jdcaballerov <743513+jdcaballerov@users.noreply.github.com>
Closed
Contributor
|
This PR has been automatically locked since there has not been any activity in past 14 days after it was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The description doesn't fully match the functionality of the call. Take for instance this transaction. The transfer in the transaction is never reported for the mint involved . i.e the transaction never gets returned since the mint is not passed but the two ATAs thus misleading.
Summary of Changes
Modification suggestion