This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Clean up demote program write lock feature#21949
Merged
jstarry merged 2 commits intosolana-labs:masterfrom Dec 16, 2021
Merged
Conversation
jstarry
force-pushed
the
remove-demote-program
branch
from
69a2131 to
b917fff
Compare
CriesofCarrots
approved these changes
Dec 16, 2021
Contributor
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
Looks good, thanks! (...until the next time we need a feature in is_writable() ;) )
mergify
Bot
removed
the
automerge
Contributor
|
automerge label removed due to a CI failure |
Codecov Report
@@ Coverage Diff @@
## master #21949 +/- ##
=======================================
Coverage 81.2% 81.2%
=======================================
Files 516 516
Lines 144368 144319 -49
=======================================
- Hits 117326 117310 -16
+ Misses 27042 27009 -33 |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 16, 2021
* Clean up demote program write lock feature * fix test (cherry picked from commit 6ff0be6) # Conflicts: # programs/bpf_loader/src/syscalls.rs # runtime/src/accounts.rs
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
demote_program_write_locksfeature is activated on all clusters and can be cleaned upSummary of Changes
demote_program_write_locksbehavior to enabledFixes #