This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Ensure AncestorHashesSerice selects an open port#21919
Merged
carllin merged 2 commits intosolana-labs:masterfrom Dec 18, 2021
Merged
Ensure AncestorHashesSerice selects an open port#21919carllin merged 2 commits intosolana-labs:masterfrom
carllin merged 2 commits intosolana-labs:masterfrom
Conversation
carllin
force-pushed
the
FixAncestorHashes
branch
from
390c682 to
142e901
Compare
carllin
force-pushed
the
FixAncestorHashes
branch
from
142e901 to
ed74b03
Compare
Codecov Report
@@ Coverage Diff @@
## master #21919 +/- ##
=======================================
Coverage 81.2% 81.3%
=======================================
Files 516 516
Lines 144286 144300 +14
=======================================
+ Hits 117294 117318 +24
+ Misses 26992 26982 -10 |
carllin
changed the title
t-nelson
reviewed
Dec 17, 2021
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
mergify
Bot
dismissed
AshwinSekar’s stale review
Pull request has been modified.
mergify Bot
pushed a commit
that referenced
this pull request
Dec 18, 2021
(cherry picked from commit 7f6fb69)
carllin
added a commit
that referenced
this pull request
Dec 28, 2021
(cherry picked from commit 7f6fb69)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Port on which AncestorHashes receives responses is randomly selected and may not be open
Summary of Changes
Ensure AncestorHashes is passed a port that was opened within the validator's specified open port range
Fixes #