This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add feature for capping accounts data len#21912
Closed
brooksprumo wants to merge 1 commit intosolana-labs:masterfrom
Closed
Add feature for capping accounts data len#21912brooksprumo wants to merge 1 commit intosolana-labs:masterfrom
brooksprumo wants to merge 1 commit intosolana-labs:masterfrom
Conversation
brooksprumo
added
blocked
brooksprumo
changed the title
brooksprumo
changed the title
Contributor
Author
mvines
reviewed
Dec 15, 2021
brooksprumo
force-pushed
the
accounts-data-len-5-feature-gate
branch
from
0431a71 to
d8fb0be
Compare
brooksprumo
force-pushed
the
accounts-data-len-5-feature-gate
branch
from
d8fb0be to
a0b9170
Compare
brooksprumo
added
CI
Codecov Report
@@ Coverage Diff @@
## master #21912 +/- ##
========================================
Coverage 81.2% 81.3%
========================================
Files 516 516
Lines 144284 144365 +81
========================================
+ Hits 117256 117381 +125
+ Misses 27028 26984 -44 |
Contributor
|
Usually we just add these pieces along with the featurizing logic peices |
Contributor
Author
|
Closing. Will pull this into the code that uses the feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Before adding in logic that will fail instructions that exceed the maximum accounts data len, there needs to be a feature flag to gate the changes. That feature doesn't exist yet.
For more context see the main issue #21604
Summary of Changes
Add the feature.