Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Add option accountsdb-plugin-config to test-validator#21904

Merged
mvines merged 1 commit intosolana-labs:masterfrom
fanatid:test-validator-accountsdb
Dec 15, 2021
Merged

Add option accountsdb-plugin-config to test-validator#21904
mvines merged 1 commit intosolana-labs:masterfrom
fanatid:test-validator-accountsdb

Conversation

@fanatid
Copy link
Copy Markdown
Contributor

@fanatid fanatid commented Dec 14, 2021

Accountsdb plugins need to be tested somehow. This PR allows load plugins in the test validator.

@mergify mergify Bot added the community Community contribution label Dec 14, 2021
@mergify mergify Bot requested a review from a team December 14, 2021 20:17
@fanatid
Copy link
Copy Markdown
Contributor Author

fanatid commented Dec 15, 2021

Errors from CI:

ci/rust-version.sh: line 41: cargo: command not found
./ci/test-stable-bpf.sh: Missing toolchain? Installing...: 1.57.0
ci/rust-version.sh: line 43: rustup: command not found

@mvines mvines added the v1.9 label Dec 15, 2021
@mvines
Copy link
Copy Markdown
Contributor

mvines commented Dec 15, 2021

Nice! I restarted those jobs, there was a bad CI agent in the queue earlier

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2021

Codecov Report

Merging #21904 (b544d6f) into master (a400b5e) will decrease coverage by 0.0%.
The diff coverage is 80.8%.

@@            Coverage Diff            @@
##           master   #21904     +/-   ##
=========================================
- Coverage    81.3%    81.3%   -0.1%     
=========================================
  Files         516      516             
  Lines      144033   144241    +208     
=========================================
+ Hits       117139   117293    +154     
- Misses      26894    26948     +54     

@mvines
Copy link
Copy Markdown
Contributor

mvines commented Dec 15, 2021

Thanks for another useful PR!

@mvines mvines merged commit c2a94a8 into solana-labs:master Dec 15, 2021
@fanatid fanatid deleted the test-validator-accountsdb branch December 15, 2021 07:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community Community contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants