This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Refactor: Remove Rc from PreAccount and InvokeContext::get_account()#21882
Merged
Lichtso merged 2 commits intosolana-labs:masterfrom Dec 14, 2021
Merged
Conversation
…index() in order to remove Rc from return type.
Lichtso
force-pushed
the
refactor/remove_rc_from_pre_account_and_get_account
branch
from
daea395 to
ab3476b
Compare
Codecov Report
@@ Coverage Diff @@
## master #21882 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 516 516
Lines 144217 144216 -1
=========================================
- Hits 117268 117257 -11
- Misses 26949 26959 +10 |
Lichtso
deleted the
refactor/remove_rc_from_pre_account_and_get_account
branch
This was referenced Dec 15, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Rc<RefCell<AccountSharedData>>in the program-runtime is overkill andAccountSharedDatawould suffice for thePreAccounts. AlsoInvokeContext::get_account()does not need to clone theRc.This PR is a spinoff / preparation for #21706.
Summary of Changes
.clone()of theAccountSharedDatafromPreAccountintoInvokeContext.Rc<RefCell<AccountSharedData>>byAccountSharedDatain thePreAccounts.get_account()intofind_index_of_account()andget_account_at_index()in order to removeRcfrom return type.Fixes #