This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix subtraction overflow#21871
Merged
carllin merged 1 commit intosolana-labs:masterfrom Dec 14, 2021
Merged
Conversation
AshwinSekar
previously approved these changes
Dec 14, 2021
carllin
force-pushed
the
FixAncestorHashes
branch
from
4005fa1 to
62807e9
Compare
mergify
Bot
dismissed
AshwinSekar’s stale review
Pull request has been modified.
Codecov Report
@@ Coverage Diff @@
## master #21871 +/- ##
=========================================
- Coverage 81.3% 81.2% -0.1%
=========================================
Files 516 516
Lines 144033 144225 +192
=========================================
+ Hits 117139 117249 +110
- Misses 26894 26976 +82 |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 14, 2021
(cherry picked from commit cb395ab)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AncestorHashesService can overflow on bad response
Summary of Changes
Fixes #