This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add reject_all_writable_sections feature gate#21826
Closed
alessandrod wants to merge 1 commit intosolana-labs:masterfrom
Closed
Add reject_all_writable_sections feature gate#21826alessandrod wants to merge 1 commit intosolana-labs:masterfrom
alessandrod wants to merge 1 commit intosolana-labs:masterfrom
Conversation
When reject_writable_data_sections is turned on, programs with writable data sections (global mutable state) are rejected. See solana-labs/rbpf#240
alessandrod
force-pushed
the
writable-data-sections
branch
from
f902f63 to
59b5aaa
Compare
alessandrod
changed the title
Contributor
Author
|
Renamed the feature name to |
Contributor
|
Now covered in #21880 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
solana-labs/rbpf#240 adds a config option to reject programs with global mutable state.
Summary of Changes
This PR adds a
reject_writable_data_sectionsfeature gate, which once turned on rejects programs with global mutable state.