This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Document solana_program::instruction#21817
Merged
mergify[bot] merged 2 commits intosolana-labs:masterfrom Dec 14, 2021
Merged
Conversation
brson
force-pushed
the
docs-instruction
branch
6 times, most recently
from
3229d6a to
cdcd75c
Compare
Contributor
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
Couple nits, otherwise looks great
Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
Contributor
Author
|
Suggestions committed. Thanks for catching my typos. Great eyes. |
CriesofCarrots
added
automerge
CriesofCarrots
approved these changes
Dec 14, 2021
Contributor
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
Excellent, thank you!
Codecov Report
@@ Coverage Diff @@
## master #21817 +/- ##
=======================================
Coverage 81.3% 81.3%
=======================================
Files 516 516
Lines 144033 144033
=======================================
+ Hits 117139 117144 +5
+ Misses 26894 26889 -5 |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 14, 2021
* Document solana_program::instruction * Apply suggestions from code review Co-authored-by: Tyera Eulberg <teulberg@gmail.com> Co-authored-by: Tyera Eulberg <teulberg@gmail.com> (cherry picked from commit dcb5849)
mergify Bot
added a commit
that referenced
this pull request
Dec 15, 2021
* Document solana_program::instruction * Apply suggestions from code review Co-authored-by: Tyera Eulberg <teulberg@gmail.com> Co-authored-by: Tyera Eulberg <teulberg@gmail.com> (cherry picked from commit dcb5849) Co-authored-by: Brian Anderson <andersrb@gmail.com>
Closed
Contributor
|
This PR has been automatically locked since there has not been any activity in past 14 days after it was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hackers love docs and they don't get enough of them.
Summary of Changes
This adds docs and examples for everything in the instruction module. Please review the "Specifying account metadata" section closely.
I made the
checked_addfunction hidden as it seems to be intended for internal use.cc @askibin I appreciated your review of my last doc patch.