This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Rename Packets to PacketBatch#21794
Merged
jstarry merged 1 commit intosolana-labs:masterfrom Dec 11, 2021
Merged
Conversation
jstarry
force-pushed
the
packet-batch
branch
13 times, most recently
from
62a86fe to
93a09b1
Compare
jstarry
added
automerge
mergify
Bot
removed
the
automerge
Contributor
|
automerge label removed due to a CI failure |
jstarry
force-pushed
the
packet-batch
branch
from
93a09b1 to
aafff35
Compare
Codecov Report
@@ Coverage Diff @@
## master #21794 +/- ##
=========================================
- Coverage 81.6% 81.2% -0.4%
=========================================
Files 511 515 +4
Lines 143320 144029 +709
=========================================
+ Hits 116976 117077 +101
- Misses 26344 26952 +608 |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 11, 2021
(cherry picked from commit 254ef3e) # Conflicts: # core/src/ancestor_hashes_service.rs # core/src/banking_stage.rs # core/src/cluster_info_vote_listener.rs # core/src/fetch_stage.rs # core/src/serve_repair.rs # core/src/shred_fetch_stage.rs # core/src/sigverify_stage.rs # core/src/verified_vote_packets.rs # core/src/window_service.rs # gossip/src/cluster_info.rs # ledger/src/entry.rs # streamer/src/streamer.rs
mergify Bot
pushed a commit
that referenced
this pull request
Dec 11, 2021
(cherry picked from commit 254ef3e) # Conflicts: # core/src/verified_vote_packets.rs
mergify Bot
added a commit
that referenced
this pull request
Dec 11, 2021
* Rename Packets to PacketBatch (#21794) (cherry picked from commit 254ef3e) # Conflicts: # core/src/ancestor_hashes_service.rs # core/src/banking_stage.rs # core/src/cluster_info_vote_listener.rs # core/src/fetch_stage.rs # core/src/serve_repair.rs # core/src/shred_fetch_stage.rs # core/src/sigverify_stage.rs # core/src/verified_vote_packets.rs # core/src/window_service.rs # gossip/src/cluster_info.rs # ledger/src/entry.rs # streamer/src/streamer.rs * resolve conflicts Co-authored-by: Justin Starry <justin@solana.com>
t-nelson
added a commit
to t-nelson/solana
that referenced
this pull request
Dec 13, 2021
…olana-labs#21804)" This reverts commit 39e27b1.
tao-stones
pushed a commit
that referenced
this pull request
Dec 13, 2021
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 16, 2021
…1794) (solana-labs#21804)"" This reverts commit 13d40d6.
CriesofCarrots
pushed a commit
that referenced
this pull request
Dec 17, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
It's not always clear when a list of "packets" is a list of individual packets or a list of packet "batches."
Summary of Changes
Rename things to be clearer, no behavior changes
Fixes #