This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Expand docs for Pubkey::create_program_address#21750
Merged
mergify[bot] merged 2 commits intosolana-labs:masterfrom Dec 9, 2021
Merged
Expand docs for Pubkey::create_program_address#21750mergify[bot] merged 2 commits intosolana-labs:masterfrom
mergify[bot] merged 2 commits intosolana-labs:masterfrom
Conversation
CriesofCarrots
previously approved these changes
Dec 9, 2021
Contributor
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
Ah, thanks so much for researching this! I wasn't clued in to this use-case.
Asking Jack to confirm, but lgtm.
jackcmay
previously approved these changes
Dec 9, 2021
mergify
Bot
dismissed stale reviews from CriesofCarrots and jackcmay
Pull request has been modified.
CriesofCarrots
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #21750 +/- ##
=========================================
- Coverage 81.4% 81.4% -0.1%
=========================================
Files 511 511
Lines 143469 143469
=========================================
- Hits 116840 116827 -13
- Misses 26629 26642 +13 |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Expand docs for Pubkey::create_program_address * Update sdk/program/src/pubkey.rs Co-authored-by: Tyera Eulberg <teulberg@gmail.com> (cherry picked from commit 6919c48)
jstarry
pushed a commit
that referenced
this pull request
Dec 10, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
create_program_addressdocs say that it has no use, but it is useful for verifying PDAs. re #21528 (comment)Summary of Changes
Expand the docs to explain how to use
create_program_address.cc @askibin