This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Remove activated feature that checks tx signature len#21747
Merged
jstarry merged 1 commit intosolana-labs:masterfrom Dec 14, 2021
Merged
Remove activated feature that checks tx signature len#21747jstarry merged 1 commit intosolana-labs:masterfrom
jstarry merged 1 commit intosolana-labs:masterfrom
Conversation
jstarry
force-pushed
the
remove-extra-sig-feature
branch
from
2269edd to
b0f22e8
Compare
jstarry
force-pushed
the
remove-extra-sig-feature
branch
from
b0f22e8 to
9a2f7e5
Compare
Codecov Report
@@ Coverage Diff @@
## master #21747 +/- ##
=======================================
Coverage 81.4% 81.4%
=======================================
Files 511 511
Lines 143469 143459 -10
=======================================
- Hits 116840 116832 -8
+ Misses 26629 26627 -2 |
Contributor
Author
|
@joncinque could you sanity check this, please? |
joncinque
approved these changes
Dec 14, 2021
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
This was surprisingly tricky, but looks good!
mergify Bot
pushed a commit
that referenced
this pull request
Dec 14, 2021
(cherry picked from commit e547691)
jstarry
added a commit
that referenced
this pull request
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Now that the feature to check transaction signatures length is activated on all clusters, it can be removed and the length check can be moved into transaction sanitization checking.
Summary of Changes
Fixes #