Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Add Accountsdb plugin documentations#21746

Merged
lijunwangs merged 12 commits intosolana-labs:masterfrom
lijunwangs:accountsdb_plugin_docs
Dec 10, 2021
Merged

Add Accountsdb plugin documentations#21746
lijunwangs merged 12 commits intosolana-labs:masterfrom
lijunwangs:accountsdb_plugin_docs

Conversation

@lijunwangs
Copy link
Copy Markdown
Contributor

Problem

Summary of Changes

  1. Add the public facing documentation about the plugin framework: explaining the interface, how to load plugin and the example PostgreSQL plugin implementation.
  2. Updated the rust documentation for the plugin interfaces for accounts and slot.
  3. This changes are targeted for v1.8. Information about transactions will be updated later.
    Fixes #

Comment thread accountsdb-plugin-interface/src/accountsdb_plugin_interface.rs Outdated
Comment thread accountsdb-plugin-interface/src/accountsdb_plugin_interface.rs Outdated
Comment thread accountsdb-plugin-interface/src/accountsdb_plugin_interface.rs Outdated
Comment thread accountsdb-plugin-interface/src/accountsdb_plugin_interface.rs Outdated
Comment thread accountsdb-plugin-interface/src/accountsdb_plugin_interface.rs Outdated
Comment thread accountsdb-plugin-interface/src/accountsdb_plugin_interface.rs Outdated
Comment thread accountsdb-plugin-interface/src/accountsdb_plugin_interface.rs Outdated
Comment thread docs/src/developing/plugins/accountsdb_plugin.md
Comment thread accountsdb-plugin-interface/src/accountsdb_plugin_interface.rs
Comment thread accountsdb-plugin-interface/src/accountsdb_plugin_interface.rs Outdated
lijunwangs and others added 2 commits December 9, 2021 16:25
Copy link
Copy Markdown
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the wrapping! A few typos and grammar fixes. Info looks good!
At first, I wasn't sure about having all the postgres specifics, but it's useful as a complete walkthrough and offering non-default configuration details, so I came around :)

Comment thread docs/src/developing/plugins/accountsdb_plugin.md Outdated
Comment thread docs/src/developing/plugins/accountsdb_plugin.md Outdated
Comment thread docs/src/developing/plugins/accountsdb_plugin.md Outdated
Comment thread docs/src/developing/plugins/accountsdb_plugin.md Outdated
Comment thread docs/src/developing/plugins/accountsdb_plugin.md Outdated
Comment thread docs/src/developing/plugins/accountsdb_plugin.md Outdated
Comment thread docs/src/developing/plugins/accountsdb_plugin.md Outdated
Comment thread docs/src/developing/plugins/accountsdb_plugin.md Outdated
Comment thread docs/src/developing/plugins/accountsdb_plugin.md Outdated
Comment thread docs/src/developing/plugins/accountsdb_plugin.md Outdated
CriesofCarrots
CriesofCarrots previously approved these changes Dec 10, 2021
Copy link
Copy Markdown
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ a couple nits, then :shipit:

Comment thread docs/src/developing/plugins/accountsdb_plugin.md Outdated
Comment thread docs/src/developing/plugins/accountsdb_plugin.md Outdated
Comment thread docs/src/developing/plugins/accountsdb_plugin.md Outdated
Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
@mergify mergify Bot dismissed CriesofCarrots’s stale review December 10, 2021 23:49

Pull request has been modified.

@lijunwangs lijunwangs merged commit 379e3ec into solana-labs:master Dec 10, 2021
lijunwangs added a commit to lijunwangs/solana that referenced this pull request Dec 11, 2021
Add the public facing documentation about the plugin framework: explaining the interface, how to load plugin and the example PostgreSQL plugin implementation.
Updated the rust documentation for the plugin interfaces for accounts and slot.
This changes are targeted for v1.8. Information about transactions will be updated later.
lijunwangs added a commit to lijunwangs/solana that referenced this pull request Dec 11, 2021
Add the public facing documentation about the plugin framework: explaining the interface, how to load plugin and the example PostgreSQL plugin implementation.
Updated the rust documentation for the plugin interfaces for accounts and slot.
This changes are targeted for v1.8. Information about transactions will be updated later.
lijunwangs added a commit that referenced this pull request Dec 11, 2021
Add the public facing documentation about the plugin framework: explaining the interface, how to load plugin and the example PostgreSQL plugin implementation.
Updated the rust documentation for the plugin interfaces for accounts and slot.
This changes are targeted for v1.8. Information about transactions will be updated later.
lijunwangs added a commit to lijunwangs/solana that referenced this pull request Dec 11, 2021
Add the public facing documentation about the plugin framework: explaining the interface, how to load plugin and the example PostgreSQL plugin implementation.
Updated the rust documentation for the plugin interfaces for accounts and slot.
This changes are targeted for v1.8. Information about transactions will be updated later.
lijunwangs added a commit that referenced this pull request Dec 11, 2021
* Add Accountsdb plugin documentations (#21746)

Add the public facing documentation about the plugin framework: explaining the interface, how to load plugin and the example PostgreSQL plugin implementation.
Updated the rust documentation for the plugin interfaces for accounts and slot.
This changes are targeted for v1.8. Information about transactions will be updated later.

* fmt issue
t-nelson added a commit to t-nelson/solana that referenced this pull request Dec 13, 2021
tao-stones pushed a commit that referenced this pull request Dec 13, 2021
CriesofCarrots pushed a commit to CriesofCarrots/solana that referenced this pull request Dec 16, 2021
CriesofCarrots pushed a commit that referenced this pull request Dec 17, 2021
@brooksprumo brooksprumo mentioned this pull request Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants