This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add StakesCache struct to abstract away locking#21738
Merged
jstarry merged 1 commit intosolana-labs:masterfrom Dec 10, 2021
Merged
Add StakesCache struct to abstract away locking#21738jstarry merged 1 commit intosolana-labs:masterfrom
jstarry merged 1 commit intosolana-labs:masterfrom
Conversation
mergify
Bot
dismissed
brooksprumo’s stale review
Pull request has been modified.
Contributor
Author
|
Rebased off master and resolved conflicts which involved moving |
mergify
Bot
removed
the
automerge
Contributor
|
automerge label removed due to a CI failure |
Codecov Report
@@ Coverage Diff @@
## master #21738 +/- ##
=========================================
- Coverage 81.4% 81.4% -0.1%
=========================================
Files 511 511
Lines 143469 143489 +20
=========================================
+ Hits 116840 116844 +4
- Misses 26629 26645 +16 |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 10, 2021
(cherry picked from commit fd175c1) # Conflicts: # runtime/src/bank.rs # runtime/src/serde_snapshot/tests.rs # runtime/src/stakes.rs
mergify Bot
pushed a commit
that referenced
this pull request
Dec 10, 2021
(cherry picked from commit fd175c1) # Conflicts: # runtime/src/bank.rs # runtime/src/stakes.rs
Contributor
Author
|
@Mergifyio backport v1.8 |
Contributor
Author
|
@Mergifyio backport v1.9 |
Contributor
✅ Backports have been createdDetails
|
Contributor
✅ Backports have been createdDetails
|
jstarry
added a commit
that referenced
this pull request
Dec 10, 2021
jstarry
added a commit
that referenced
this pull request
Dec 11, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Stakes cache locking details is leaking into
Bankand there's no single place to prepare new stakes cache updates before grabbing a lock.Summary of Changes
Create a thin wrapper struct around a
RwLockwrappedStakescache instanceThis PR lays the groundwork for new deserialization optimizations in #21733
Fixes #