This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add return types to generate_index()#21735
Merged
brooksprumo merged 4 commits intosolana-labs:masterfrom Dec 9, 2021
Merged
Conversation
brooksprumo
commented
Dec 9, 2021
brooksprumo
changed the title
brooksprumo
force-pushed
the
generate-index-result
branch
from
648fcd5 to
8260c41
Compare
Codecov Report
@@ Coverage Diff @@
## master #21735 +/- ##
=========================================
- Coverage 81.6% 81.4% -0.2%
=========================================
Files 511 511
Lines 143320 143425 +105
=========================================
- Hits 116976 116816 -160
- Misses 26344 26609 +265 |
mergify Bot
pushed a commit
that referenced
this pull request
Jan 4, 2022
(cherry picked from commit 1528f85)
This was referenced Jan 5, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation to get (and return) the total accounts data len during generate index, I'm adding structs to
generate_index()andgenerate_index_for_slot(). This makes the return values self-documenting.I personally find this way to be helpful for functions that return non-obvious values. I.e. I wouldn't expect
generate_index()'s return value to be the the accounts data len. IMO, having a struct with the named fields does help with that.