simulateTransaction now returns the correct error code if accounts are provided as input

[mvines]

An alternative to #21677

Fixes #21655

[mvines]

@zfedoran - hey want do you think about this version of your fix?

[zfedoran]

@mvines looks like a more robust fix. The only concern I have is whether it is somehow possible for a post_simulation_account to exist without it also being listed in the transaction itself? Derived program address maybe?

[mvines]

The only concern I have is whether it is somehow possible for a post_simulation_account to exist without it also being listed in the transaction itself? Derived program address maybe?

Derived program addresses still need to be declared in a transaction for them to be accessible to the program, so I think we're ok here.

[codecov]

Codecov Report

Merging #21707 (651103d) into master (923720f) will increase coverage by 0.0%.
The diff coverage is 94.4%.

@@           Coverage Diff           @@
##           master   #21707   +/-   ##
=======================================
  Coverage    81.6%    81.6%           
=======================================
  Files         511      511           
  Lines      143320   143325    +5     
=======================================
+ Hits       116963   116993   +30     
+ Misses      26357    26332   -25