This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Bump RpcClient node versions#21612
Merged
mergify[bot] merged 2 commits intosolana-labs:masterfrom Dec 4, 2021
Merged
Conversation
brooksprumo
approved these changes
Dec 4, 2021
Contributor
brooksprumo
left a comment
brooksprumo
left a comment
There was a problem hiding this comment.
Yes, thanks for fixing this! Looks good to me.
CriesofCarrots
added
the
automerge
jackcmay
approved these changes
Dec 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #21612 +/- ##
=========================================
- Coverage 81.7% 81.6% -0.1%
=========================================
Files 510 510
Lines 142502 142502
=========================================
- Hits 116434 116393 -41
- Misses 26068 26109 +41 |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 4, 2021
* Bump blockhash/fee api check versions * Bump snapshot api check version (cherry picked from commit 3e5a5a8)
jbiseda
pushed a commit
to jbiseda/solana
that referenced
this pull request
Dec 6, 2021
* Bump blockhash/fee api check versions * Bump snapshot api check version
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
solana airdrop 1with a master or beta client is currently incompatible with devnet/mainnet-beta. This is because it is attempting to call the non-existent getLatestBlockhash RPC endpoint because the cluster satisfies the get_node_version conditional due to v1.8 jumping the normal release process.Summary of Changes
Bump checked version to be in sync for master/v1.9
Do same for getHighestSnapshotSlot. I think this is correct. Please confirm, @brooksprumo 🙏
cc @jackcmay
Fixes #21611