Vote every number of ticks #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-solana
reviewed
Dec 12, 2018
src/replay_stage.rs
Outdated
| @@ -25,6 +25,9 @@ use std::thread::{self, Builder, JoinHandle}; | |||
| use std::time::Duration; | |||
| use std::time::Instant; | |||
|
|
|||
| pub const NUM_TICK_PER_VOTE: u64 = 8; | |||
There was a problem hiding this comment.
please call this BLOCK_ to harmonize with book terminology ;)
rob-solana
approved these changes
Dec 12, 2018
rob-solana
approved these changes
Dec 13, 2018
pgarg66
commented
Dec 13, 2018
| inc_new_counter_info!("validator-vote_sent", 1); | ||
| vote_blob_sender.send(vec![shared_blob])?; | ||
|
|
||
| if let Ok(shared_blob) = create_new_signed_vote_blob(&last_id, vote_account, bank, cluster_info) |
There was a problem hiding this comment.
Filed an issue to store failed votes: #2152
(as votes will be cached and transmitted when leader is available)
rob-solana
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Validators are voting once per second. Voting should happen every block period (number of ticks)
Summary of Changes
Validators check current tick count and vote if its modulo block period.
Also, cap number of entries that are being processed in replay stage.
Fixes #1428