This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Refactor: Cleanup program-runtime dyn Traits#21395
Merged
Lichtso merged 6 commits intosolana-labs:masterfrom Nov 23, 2021
Merged
Refactor: Cleanup program-runtime dyn Traits#21395Lichtso merged 6 commits intosolana-labs:masterfrom
Lichtso merged 6 commits intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21395 +/- ##
========================================
Coverage 81.5% 81.5%
========================================
Files 500 504 +4
Lines 140604 141468 +864
========================================
+ Hits 114704 115432 +728
- Misses 25900 26036 +136 |
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
* Unifies dyn Trait ComputeMeter, ThisComputeMeter and TransactionComputeMeter. * Unifies dyn Trait Logger and ThisLogger. * Moves Logger to log_collector.rs * Unifies Logger and LogCollector. * Removes inner RefCell from LogCollector. * Adds the log::debug!() message to ic_logger_msg!() again.
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…)" This reverts commit abab339.
jackcmay
reviewed
Nov 29, 2021
| if logger.log_enabled() { | ||
| logger.log(&format!("Program log: {}", message)); | ||
| } | ||
| ic_msg!(invoke_context, "Program log: {}", message); |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There are
dyn Traits with only one implementation in the program-runtime crate.Summary of Changes
trait ComputeMeter,ThisComputeMeterandTransactionComputeMeter.trait Logger,ThisLoggerandLogCollector.RefCellfromLogCollector.Fixes #