This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Moves NonceKeyedAccount from the SDK to the Runtime.#20954
Merged
Lichtso merged 1 commit intosolana-labs:masterfrom Oct 25, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20954 +/- ##
=========================================
+ Coverage 81.4% 81.5% +0.1%
=========================================
Files 531 496 -35
Lines 141636 139627 -2009
Branches 295 0 -295
=========================================
- Hits 115312 113896 -1416
+ Misses 26224 25731 -493
+ Partials 100 0 -100 |
Lichtso
deleted the
refactor/move_NonceKeyedAccount_from_sdk_to_runtime
branch
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…labs#20954)" This reverts commit 70ea64b.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
NonceKeyedAccountis only used in the runtime and needs anInvokeContextfor testing.So it makes sense to move it to the runtime instead to avoid cyclic dependencies once
MockInvokeContextis replaced.Summary of Changes
Moves
NonceKeyedAccountfrom the SDK to the Runtime.Fixes #