Use custom LLVM #1971
Merged
Use custom LLVM #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
reviewed
Nov 30, 2018
|
@mvines, CI passed, any other feedback? Anything I might have missed with the SDK, web3, etc...? |
|
I think we want to include Instead we can make the downstream users run install.sh, so that'll be a change in solana-web3.js once this PR merges. There reason is LLVM is many MBs and I don't think we want those MBs packaged in the npmjs module Beyond that the PR looks good to me |
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
…olana-labs#1971) Bumps [@babel/node](https://github.com/babel/babel/tree/HEAD/packages/babel-node) from 7.14.5 to 7.14.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.14.7/packages/babel-node) --- updated-dependencies: - dependency-name: "@babel/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
brooksprumo
pushed a commit
to brooksprumo/solana
that referenced
this pull request
Jul 12, 2024
…up (solana-labs#1971) * blockstore: only consume duplicate proofs from root_slot + 1 on startup * pr feedback: update test comments * pr feedback: add pub behind dcou for test fns
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Jul 18, 2024
… startup (backport of solana-labs#1971) (solana-labs#2114) blockstore: only consume duplicate proofs from root_slot + 1 on startup (solana-labs#1971) * blockstore: only consume duplicate proofs from root_slot + 1 on startup * pr feedback: update test comments * pr feedback: add pub behind dcou for test fns (cherry picked from commit 2a48564) Co-authored-by: Ashwin Sekar <[email protected]>
willhickey
pushed a commit
that referenced
this pull request
Aug 31, 2024
…n startup (backport of #1971) (#2113) * blockstore: only consume duplicate proofs from root_slot + 1 on startup (#1971) * blockstore: only consume duplicate proofs from root_slot + 1 on startup * pr feedback: update test comments * pr feedback: add pub behind dcou for test fns (cherry picked from commit 2a48564) * fix conflicts --------- Co-authored-by: Ashwin Sekar <[email protected]> Co-authored-by: Ashwin Sekar <[email protected]>
behzadnouri
pushed a commit
to behzadnouri/solana
that referenced
this pull request
Oct 10, 2024
…n startup (backport of solana-labs#1971) (solana-labs#2113) * blockstore: only consume duplicate proofs from root_slot + 1 on startup (solana-labs#1971) * blockstore: only consume duplicate proofs from root_slot + 1 on startup * pr feedback: update test comments * pr feedback: add pub behind dcou for test fns (cherry picked from commit 2a48564) * fix conflicts --------- Co-authored-by: Ashwin Sekar <[email protected]> Co-authored-by: Ashwin Sekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solana requires modifications to LLVM that have not been upstreamed.
Summary of Changes
Customized LLVM repos are being maintained by the Solana Github organization and built/released via the repo: https://github.com/solana-labs/llvm-builder
The changes in this PR switches Solana over to using the custom LLVM which includes downloading and installing the release from llvm-builder during sdk install.
docker-llvm was maintained in the Solana repo, it has been moved to llvm-builder repo.
Fixes #