This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Reduce payer balance needed to deploy programs#19645
Merged
jstarry merged 4 commits intosolana-labs:masterfrom Sep 18, 2021
Merged
Reduce payer balance needed to deploy programs#19645jstarry merged 4 commits intosolana-labs:masterfrom
jstarry merged 4 commits intosolana-labs:masterfrom
Conversation
jstarry
force-pushed
the
cheaper-deploys
branch
from
17b2c50 to
af0d25c
Compare
Codecov Report
@@ Coverage Diff @@
## master #19645 +/- ##
=========================================
- Coverage 82.6% 82.6% -0.1%
=========================================
Files 478 478
Lines 133443 133462 +19
=========================================
- Hits 110334 110326 -8
- Misses 23109 23136 +27 |
Contributor
Author
|
Blocked on #18629 |
Contributor
|
I'm working on #18629 |
Contributor
Contributor
|
Btw, if this was blocked I would expect a test that shows that :-) |
jstarry
force-pushed
the
cheaper-deploys
branch
from
af0d25c to
22e5ff9
Compare
jstarry
commented
Sep 15, 2021
| program_id, | ||
| ); | ||
|
|
||
| // pass an extra account to avoid the overly strict UnbalancedInstruction error |
Contributor
Author
Contributor
Author
|
This is ready for review @jackcmay, as mentioned above I hit the overly restrictive balanced instruction check but it's easy to work around for now |
Contributor
jackcmay
previously approved these changes
Sep 16, 2021
mergify
Bot
dismissed
jackcmay’s stale review
Pull request has been modified.
mergify
Bot
removed
the
automerge
Contributor
|
automerge label removed due to a CI failure |
jstarry
force-pushed
the
cheaper-deploys
branch
from
3acb841 to
9a44c85
Compare
Contributor
|
automerge label removed due to a CI failure |
mergify
Bot
removed
the
automerge
mergify Bot
pushed a commit
that referenced
this pull request
Sep 18, 2021
* Reduce payer balance needed to deploy programs * Fix test and unbalanced ix error * fix test * fix up tests (cherry picked from commit efd0245) # Conflicts: # programs/bpf_loader/src/lib.rs
mergify Bot
added a commit
that referenced
this pull request
Sep 18, 2021
) * Reduce payer balance needed to deploy programs (#19645) * Reduce payer balance needed to deploy programs * Fix test and unbalanced ix error * fix test * fix up tests (cherry picked from commit efd0245) # Conflicts: # programs/bpf_loader/src/lib.rs * fix conflicts Co-authored-by: Justin Starry <justin@solana.com>
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
* Reduce payer balance needed to deploy programs * Fix test and unbalanced ix error * fix test * fix up tests
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Program deploys require more SOL than necessary for a successful deploy.
The payer balance is used to pay for programdata account creation before the payer is credited for the deploy buffer account. The buffer account balance is about the same as the required programdata balance, so a payer basically has to cover twice the rent cost than they need to.
Summary of Changes
Fixes #