This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Backport #17319#19414
Closed
carllin wants to merge 1 commit intosolana-labs:v1.6from
Closed
Conversation
Contributor
Author
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
Bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
purge_slots()removes the storage entries without unrefing the containing accounts. This may lead to a bad ref count for zero lamport accounts which will then never get removed.Summary of Changes
Backport #17319 which reworked
purge_slots()to use a commonhandle_reclaims()path which takes care of the dead slot and unrefing accountsFixes #